fix[adjoint]: update polyslab in simulation bounds check to allow for… #2681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… slabs of zero thickness
groberts-flex
commented
Jul 17, 2025
| is_2d = np.isclose(extents[self.axis], 0.0) | ||
| polyslab_2d = np.isclose(np.diff(self.slab_bounds), 0.0) | ||
| sim_2d = np.isclose(extents[self.axis], 0.0) | ||
| is_2d = polyslab_2d and sim_2d |
There was a problem hiding this comment.
this is failing a unit test - actually I think maybe we don't want to add the polyslab_2d check in here for cases like the unit test that's failing where the simulation is 2d but the polyslab isn't. in that case, the polyslab should still be integrated as if it was 2d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… slabs of zero thickness