addresses performance issue when computing gradient over many frequencies #2662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timed the Autograd19ApodizedCoupler.py example: before was ~75sec to post process on my Mac, now is ~3sec
@yaugenst-flex - I think this will have some conflicts with your polyslab integration PR, so I'm happy to get that one merged first and then I can resolve conflicts on this change.
Greptile Summary
This PR implements significant performance optimizations for gradient computations over multiple frequencies in Tidy3D's autograd system. The key changes include:
The changes result in a dramatic performance improvement, reducing processing time from ~75 seconds to ~3 seconds in the Autograd19ApodizedCoupler.py example (~25x speedup).
Confidence score: 4 /5
7 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile