Unsteady heat support #2388
Merged
Unsteady heat support #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-flex
force-pushed
the
marc/unsteady-heat
branch
from
8c094ee to
cdd748a
Compare
Contributor
dbochkov-flexcompute
left a comment
dbochkov-flexcompute
left a comment
There was a problem hiding this comment.
a couple of big picture comments:
-
Not sure about having output frequency as a parameter in
UnsteadySpec. I think it could be more useful if sampling frequency can be defined for each monitor separately, similar to fdtd time monitors. Say, if I want to have just few snapshots in time for a big monitor, but then also record temperature for each step at a given point. -
For initial condition, I imagine at some point we might need to extend it to non-uniform distribution. While I would say this is out of scope for this PR, I think it would be worth ironing out how that would look like. I see two options
initial_temperature: Union[pd.PositiveFloat, SpatialDataArray, UnstructuredGridDataset]initial_temperature: Union[UniformDistibution, CustomDistribution]
probably the first option is a way to go, unless I am missing something that would require introduction of new specs?
Contributor
Author
|
Thanks @daniil for looking into this. As per usual these are great suggestions.
I'll implement this as done in fdtd. I guess my only comment is that depending on the simulation the amount of data generated during the run could be quite big since we'd be saving every time-step and then post-process only the required steps. On the other hand, once the simulation is done and post-processed, all those temp files are removed, so it is only a temporary problem?
I like this. This may be related to this issue where we want to interpolate data to a mesh. I guess once I resolve that issue we can revisit this? |
marc-flex
force-pushed
the
marc/unsteady-heat
branch
4 times, most recently
from
3752f68 to
c27caa6
Compare
marc-flex
force-pushed
the
marc/unsteady-heat
branch
from
c27caa6 to
5879960
Compare
momchil-flex
approved these changes
May 12, 2025
Collaborator
momchil-flex
left a comment
momchil-flex
left a comment
There was a problem hiding this comment.
Looks great!
The main thing that I think remains (and can't entirely be done now) is imposing some restrictions similar to what we have for fdtd sims. Maybe the only one we can really do now is just setting a limit on the maximum number of time steps in the simulation (and maybe some ball park limits on the time step). Basically users will inevitably create something that has way too many time steps for some reason, unless we limit it.
marc-flex
force-pushed
the
marc/unsteady-heat
branch
2 times, most recently
from
9b8f8ea to
1982da4
Compare
dbochkov-flexcompute
approved these changes
May 19, 2025
Contributor
dbochkov-flexcompute
left a comment
dbochkov-flexcompute
left a comment
There was a problem hiding this comment.
Looks great! A few minor comments
marc-flex
force-pushed
the
marc/unsteady-heat
branch
2 times, most recently
from
26f8015 to
87a0b12
Compare
marc-flex
force-pushed
the
marc/unsteady-heat
branch
6 times, most recently
from
de62190 to
7ae68f3
Compare
Contributor
|
Code Coverage SummaryDetailsDiff against developResults for commit: 23b312f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
|
Changed Files CoverageResults for commit: 23b312f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Heat capacity is now not a required parameter unless we run unsteady heat
marc-flex
force-pushed
the
marc/unsteady-heat
branch
from
7ae68f3 to
23b312f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for unsteady heat simulations.