-
Notifications
You must be signed in to change notification settings - Fork 60
Surface monitors #2360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Surface monitors #2360
Conversation
a56ab6e
to
2116575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I just went through and found a few typos.
description="Spatial distribution of the magnetic field on the internal and external sides of the surface.", | ||
) | ||
|
||
normal: TriangularSurfaceDataset = pd.Field( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please clarify if this points outwards for closed surfaces. Also, will this work for an open surface (2D PEC)?
f"{self._values_coords_dict} before plotting." | ||
) | ||
|
||
# compute max magnitude of vecotr field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
... start=1e-13, | ||
... stop=5e-13, | ||
... interval=2, | ||
... name='movie_monitor') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change name
UnstructuredGridDataset | ||
Data after reflextion is performed. | ||
UnstructuredDataset | ||
Dataset after reflextion is performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
see https://github.com/flexcompute/compute/pull/1239