-
Notifications
You must be signed in to change notification settings - Fork 14
Uploading diffraction beam splitter example #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Hi Guys, I created an ID notebook based on some interesting results I found while working on a customer model. I thought this might be a good candidate for the Autograd example library. Could you please take a look when you have the time? Your comments on whether this is a good fit for the library are greatly appreciated. If you decide it's not quite right for the public examples, no problem, we can just keep it as an internal reference. |
Spell Check ReportAutograd26DiffractiveBeamSplitter.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
tomflexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp this is a very informative and practical example that we should definitely include in the documentation. A few comments:
-
For the figure of merit, can you explain the exact function you defined and why you chose this form in the markdown comment above it?
-
For the diffraction power plot, I would suggest a higher contrast colormap like
hotfor example.viridisis little weak in my opinion. -
The final design performs very well, but it seems to contain small features. Maybe add a comment about it, or even better, use something to characterize (qualitatively maybe) the minimal feature size. Then put a note that to ensure minimal feature size is compliant with fab, users can play with the fab panelty, filter, etc.
yaugenst-flex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp this is really cool! Couple of comments:
- In the optimization output, there is
penalty_weight = ..., but this isn't defined anywhere. I assume this is from some prior runs? - Cell 18 markdown: The
DiffractionMonitorlink is broken (no URL defined?) - The monitors
mnt_outandmnt_sideare unused - remove? post_processimportsmatplotlibandnumpy, but these are already imported at the top of the notebook so should be removed.- In the final analysis you use
make_filter_and_projectwith a radius of 0.5, but in Cell 10 you use 0.2 - is this intentional? - I'm a bit confused about the coordinate span of the custom medium. The permittivity data only seems to cover
(length/2 - pixel_size/2) ~ 2.5umbut the box geometry is(10, 10)- is this intentional? Even if it is it seems a bit confusing. - Typo:
optmization->optimizationin cell 7 markdown - Task name is
phase_mask_examplewhich I guess is leftover from the notebook this was adapted from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs entry has inconsistent formatting, none of the other entries include the .ipynb extension
No description provided.