-
Notifications
You must be signed in to change notification settings - Fork 15
2x2 MMI Power Splitter v0. #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting results @e-g-melo! Flex agent did a great job!
-
In the intro, the note on divergences seems a bit out of place - is very chatGPT-y
-
The cell where it builds all structures, all simulation components, and the simulation itself is interesting. I guess since it's all in one cell this was all one successful prompt? If so, I'm curious if it could be trained to break up all the code it generates into different sections
-
Under key performance metrics, it looks like some redundancy appears in the lists, a classic llm listing property. Power splitting ratio and splitting imbalance are basically the same thing. That being said, the two plots for these values are nice to have. Did you deliberately tell the LLM to plot both power splitting and splitting imbalance?
-
The try-exceptions of the plot are again classic llm, probably not necessary in a notebook for tasks like these
Yes, usually the assistant organizes the setup into different cells, even for a single prompt. I think we can make it more explicit in the rules. |
No, the assistant has suggested these metrics and created all the post-processing code. In the final notebook version, we can simplify it. Thanks for your comments and suggestions! I will address them. |
Thanks @e-g-melo! I am just curious about the term “Professional cosine bends.” I don’t recall ever seeing a “Professional cosine” before, but maybe I’m just not familiar with this terminology. Also, in the post-processing, I think the MCP didn’t account for the fact that the sources are normalized. The definition of power efficiency should be |
Also, did the MCP figure out the optimized simulation size alone? Because it is pretty nice if it did. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting experiment @e-g-melo ! Maybe for the hype you can add a note in the begining of the notebook that something like "this notebook is 95% AI-generated." A few comments:
- In the markdown it mentions "wavelength sweep analysis" twice. Probably not an accurate description since FDTD is broadband.
- In the introduction it mentions MMI has broadband performance. However the equal splitting ratio doesn't seem to be very broadband?
- As Filipe pointed out, "professional s-bend" sounds quite strange. Also "high-quality s-bend" sounds a bit strange too.
- AI coding really likes try except, which I suppose is fine.
Hi @FilipeFcp! Thanks for your comments! You are right, I have excluded some of those plots. Yes, the MCP has suggested all the initial parameters. Really very nice |
Thanks @tomflexcompute! AI is really quite creative!! I have addressed all your comments. |
Spell Check ReportMMIPowerSplitter2x2.ipynb:
Checked 1 notebook(s). Found spelling errors in 1 file(s). |
@tomflexcompute, @FilipeFcp, @alec-flexcompute, Thanks for all the comments and suggestions. Please let me know if you have more comments. |
Hi! This is a kind of experiment using the MCP. The whole notebook was created using Cursor and the MCP. I have not added or modified any code, markdowns, or comments by hand (except for adding the image and metadata). Let's see how it performs :)