-
Notifications
You must be signed in to change notification settings - Fork 14
Add dipole antenna example with array factor and tapering #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
1304f64 to
57cdeea
Compare
Spell Check ReportDipoleAntennaTaper.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
57cdeea to
da422d6
Compare
da422d6 to
a31e499
Compare
|
@George-Guryev-flxcmp please edit the corresponding rst file ( Could you prepare a thumbnail image for the notebook? @yuanshen-flexcompute and I can prepare one for you as well if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@George-Guryev-flxcmp Very cool demo! The automatic simulation creation feature for arrays would potentially save users a lot of work.
Notebook comments:
- Text above cell 15 refers to warnings, which are not present because they are suppressed (until they are improved for RF). Could probably remove that reference.
- Overall, the flow is clear and simple, very appropriate for a tutorial notebook. There are a few spots where I would recommend adding a bit more explanation:
- In the preamble, the motivation and application of antenna array factor could be explained a bit more. Could also include a link to the Intro to Antenna tutorial notebook, pointing users there if they are completely new.
- The usage of
RectangularAntennaArrayCalculatorand its related functions. Here, users could benefit from a more detailed breakdown of how it works, what theory it is based on, and what are some of its assumptions and limitations etc. Feel free to include some equations (e.g. the array factor) to clarify the point. - Tapering section: same comment as above, users could use a more detailed explanation of the tapering functionality and background theory.
Aside from the notebook, I noticed that the array calculator works with Simulation instances rather than TerminalComponentModeler instances. In particular, the user first defines a Simulation, then a TerminalComponentModeler, but then awkwardly has to re-reference the Simulation as in
sim_unit = list(modeler.sim_dict.values())[0]
This sim_unit is then used in the unit cell simulation as well as the array calculator.
Is there a way we could refactor the array calculator so that the user primarily interacts with the TerminalComponentModeler rather than Simulation? Right now, the former feels like an afterthought, which can confuse users used to the RF workflow. This is very much outside the scope of the tutorial notebook, but just thought I'd bring it up anyways.
Thanks!
Summary
Adds a notebook example of a dipole antenna with array factor and tapering.
Details
The notebook demonstrates:
RectangularAntennaArrayCalculator