Skip to content

adding directional coupler example #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

FilipeFcp
Copy link
Contributor

Hi all,

I added a quick example using the directional coupler GDS, as @e-g-melo suggested.

Today, I noticed that there's a very similar notebook in the parameter sweep tutorial, so I focused more on the simulation setup and post-processing in this case.

If you have any suggestions to make it more interesting, feel free to let me know!

Copy link
Contributor

@alec-flexcompute alec-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example as always, @FilipeFcp! A couple small points:

  1. Also mention that you're creating a field monitor to check out the profile in the middle of the waveguides

  2. Above cell 9, add "(if the field decays before the runtime, the simulation will auto shut-off and we will only be billed for the Flex credits used to run)" since this will probably be one of the first examples a new user looks at

  3. In the interpolation cell, it might be helpful to add a legend in the plot

That's it, thanks for making these examples very easy to review!

Copy link
Contributor

@e-g-melo e-g-melo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new notebook @FilipeFcp! It is pretty didactic.

Some suggestions:

  1. "and create the td.Structures with those material properties" -> "and create the td.Structure with each of those material properties".
  2. We don't need the plt.show() after sim.plot_3d() in cell [8].
  3. I suggest using dB in the chart of cell [11] to display the -3dB crossing point. The current method also works, though.

Emerson

Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FilipeFcp . Definitely make sense to have this addition in the example library.

  1. The simulation domain size in y can probably be shrunk a bit more to reduce cost?
  2. In the plotting, does setting edgecolor="k" actually do anything to the plot?
  3. Might be better to plot transmission as a function of wavelength instead of frequency.
  4. For printing the transmission, might be better to only show something like 4 significant digits?
  5. Probably don't need to add the notebook to docs/features/parameter_sweep.rst?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants