-
Notifications
You must be signed in to change notification settings - Fork 13
Updating import gds tutorial #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Spell Check ReportGDSImport.ipynb:
Checked 2 notebook(s). Found spelling errors in 1 file(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp! This new organization is very helpful.
GDSCreation.ipynb
- I suggest renaming this notebook to "Layout design using gdstk" or something similar.
- Maybe you could modify this sentence a bit to avoid starting it with a variable "
sidewall_angle > 0
corresponds to a typical fabrication scenario where the base of the device is larger than the top." - I think we don't have an example of a simple directional coupler simulation (only that broadband one). Maybe we could use this layout to add a new one.
GDSImport.ipynb
- I also suggest modifying this sentence to avoid starting it with a variable name: "
sidewall_angle > 0
corresponds to a typical fabrication scenario where the base of the device is larger than the top." - "into a tidy3d.Simulation as td.Structures with..." -> "into a
td.Simulation
astd.Structures
with..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp . The splitting makes sense.
- In the GDSCreation notebook, the title still reads "Importing GDS files".
- In the GDSCreation notebook, maybe also mention PhotonForge as our own layout tool.
- Please update the rst files for the new notebook.
Thank you all for the comments. |
Create a separate one. |
Will this go in 2.9? |
@daquinteroflex I didn't know that was relevant for notebooks. Is there something I need to do? |
Hi @tomflexcompute
I split it into two notebooks, but we can delete the one about creating the file if you think it is not necessary.
I also added the files for the Multipole Expansion notebook to the JSON mapping. I learned about it from your comment on the Yuanshen notebook.