-
Notifications
You must be signed in to change notification settings - Fork 12
Tom/disordered plasmonics #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Spell check passed successfully for 1 notebook(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great notebook as always @tomflexcompute !
Just a few comments:
Before cell[2]: "we will simulation" → "we will simulate"
In cell[5]: "discorder" → "disorder"
Just out of curiosity, why not use an override region?
Totally optional: sometimes I like to use the shading='gouraud'
argument with pcolormesh
. I think it looks a bit prettier.
Thanks @FilipeFcp . All fixed. Using mesh override on the nanoparticle region doesn't help too much with convergence I found. Nonetheless I agree it might be good to show it anyway so I took this approach in this revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tomflexcompute! Thanks for this amazing notebook. It will be pretty helpful for those working on structural colors.
I don't have any additional comments about the work.
Totally optional: it would be interesting to see some reflectance spectra and their respective RGB colors. :)
Thanks @e-g-melo . That's a great idea. I've added the actual color plot in the end. |
- Added the disordered plasmonic system notebook - Fixed a missing import file mapping
9401293
to
a5a7f2a
Compare
Added a new example notebook to address the question of chromaticity calculation and diagram plotting.
As discussed in the channel @momchil-flex the result is quite sensitive on the grid size.