Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Clean up unused error and Edit code #26514

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

jacobshandling
Copy link
Contributor

Side quest while doing feature work - Edit modal and error code was completely unused

  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (7dd2f85) to head (13ba6af).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26514      +/-   ##
==========================================
+ Coverage   63.85%   63.88%   +0.02%     
==========================================
  Files        1661     1660       -1     
  Lines      159221   159154      -67     
  Branches     4145     4118      -27     
==========================================
- Hits       101671   101669       -2     
+ Misses      49613    49548      -65     
  Partials     7937     7937              
Flag Coverage Δ
frontend 53.96% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sgress454 sgress454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that I could still add an integration, and delete it, and that the edit code is indeed unused.

@jacobshandling jacobshandling merged commit f9ca0f9 into main Feb 21, 2025
14 checks passed
@jacobshandling jacobshandling deleted the clean-up-unused-ticket-destinations-code branch February 21, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants