Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDM CertificateList command for host certificates feature #26479

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

gillespi314
Copy link
Contributor

@gillespi314 gillespi314 commented Feb 19, 2025

For #23235

Checklist for submitter

  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 63.26531% with 54 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-23235-host-certificates@351f402). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/service/apple_mdm.go 42.85% 31 Missing and 13 partials ⚠️
pkg/mdm/mdmtest/apple.go 84.21% 2 Missing and 1 partial ⚠️
server/mdm/apple/apple_mdm.go 80.00% 2 Missing and 1 partial ⚠️
server/service/hosts.go 76.92% 2 Missing and 1 partial ⚠️
server/fleet/host_certificates.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##             feat-23235-host-certificates   #26479   +/-   ##
===============================================================
  Coverage                                ?   63.83%           
===============================================================
  Files                                   ?     1657           
  Lines                                   ?   159138           
  Branches                                ?     4093           
===============================================================
  Hits                                    ?   101582           
  Misses                                  ?    49601           
  Partials                                ?     7955           
Flag Coverage Δ
backend 64.66% <63.26%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gillespi314 gillespi314 marked this pull request as ready for review February 20, 2025 19:38
@gillespi314 gillespi314 requested a review from a team as a code owner February 20, 2025 19:38
@getvictor getvictor self-requested a review February 20, 2025 22:27
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gillespi314 gillespi314 merged commit adf09f0 into feat-23235-host-certificates Feb 20, 2025
34 checks passed
@gillespi314 gillespi314 deleted the 23235-host-certs-4 branch February 20, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants