Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working LUKS key escrow on non-english systems #26474

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Feb 19, 2025

#26146

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (ba8b94c) to head (e44fd68).
Report is 95 commits behind head on main.

Files with missing lines Patch % Lines
orbit/pkg/luks/luks_linux.go 0.00% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26474      +/-   ##
==========================================
- Coverage   63.88%   63.83%   -0.06%     
==========================================
  Files        1632     1656      +24     
  Lines      157962   159086    +1124     
  Branches     4089     4089              
==========================================
+ Hits       100918   101551     +633     
- Misses      49147    49595     +448     
- Partials     7897     7940      +43     
Flag Coverage Δ
backend 64.67% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo changed the title Check json from luksDump instead of parsing errors to find keyslot Check JSON from luksDump instead of parsing errors to find keyslot Feb 20, 2025
@dantecatalfamo dantecatalfamo changed the title Check JSON from luksDump instead of parsing errors to find keyslot Working LUKS key escrow on non-english systems Feb 20, 2025
@dantecatalfamo dantecatalfamo marked this pull request as ready for review February 20, 2025 15:38
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner February 20, 2025 15:38
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left two comments.

Co-authored-by: Lucas Manuel Rodriguez <[email protected]>
Co-authored-by: Lucas Manuel Rodriguez <[email protected]>
@dantecatalfamo dantecatalfamo merged commit 8917665 into main Feb 21, 2025
45 of 46 checks passed
@dantecatalfamo dantecatalfamo deleted the 26146-luks-french-keys branch February 21, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants