Fix issues related to architecture-namespaced binaries #26453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
reviewed
Feb 19, 2025
lucasmrod
reviewed
Feb 19, 2025
lucasmrod
reviewed
Feb 20, 2025
lucasmrod
reviewed
Feb 20, 2025
sgress454
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
lucasmrod
reviewed
Feb 20, 2025
| # Determine architecture (x86_64 or arm64) | ||
| ARCH="$(uname -m)" | ||
| # Standardize x86_64 to amd64 | ||
| if [ $ARCH != "arm64" ]; then ARCH="amd64"; fi |
There was a problem hiding this comment.
Probably safer to also check for the four possible values for arm64: aarch64, aarch64_be, armv8b and armv8l (see here)?
PS: My Raspberry Pi returns aarch64 for uname -m.
There was a problem hiding this comment.
Done, now you'll be able to run the Fleet website with online preview from your Raspberry Pi! 🥳
There was a problem hiding this comment.
lol, sorry, probably not a big deal, but safe to fix in case we replicate/copy this script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #26496
This PR fixes a couple of issues introduced when we started releasing separate amd64 and arm64 versions of our windows and linux binaries:
I did a weak test of the fleetctl npm installer by hardcoding what was returned for my system type and at least verified that the download url worked. Doing some more checks on VMs now.