Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Android enroll functionality #26386

Open
wants to merge 94 commits into
base: main
Choose a base branch
from
Open

Basic Android enroll functionality #26386

wants to merge 94 commits into from
+1,279 −133

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Feb 17, 2025 •
edited
Loading

For #26219

Video explaining the PR: https://www.youtube.com/watch?v=t2hmpE7N-50

This PR includes:

  • applying a default/dummy policy to Android enterprise
  • Setting up PubSub topic and subscription to point at Fleet Server
  • Generating device enrollment token
  • Enrolling a device

Although some tests were added, this PR is mostly manually tested. Integration tests are an outstanding task.

Checklist for submitter

  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Added/updated automated tests
  • Manual QA for all new/changed functionality

@getvictor
Added feature migrations
1dda21f
@getvictor
Add feature schema.sql, and fix linting errors.
d42de45
@getvictor
Setting up android directories.
88db932
@getvictor
WIP
e7c4263
@getvictor
Temporarily skipping failing test.
534d50e
@getvictor
Hooked up DB for android enteprises.
a52b3e3
@getvictor
WIP
464fca3
@getvictor
Things mostly working.
e4bf250
@getvictor
Updating android schema.
61fe90b
@getvictor
Split off Android service.
acc0c73
@getvictor
Added devices.delete to tools/android
16be7ef
@getvictor
Added architecture test.
1614233
@getvictor
Minor cleanup.
655a44d
@getvictor
Merge remote-tracking branch 'origin/main' into victor/android-poc
0cb3c92
@getvictor
Improved arch_test.go
ac001b5
@getvictor
Improved archtest
9ac4983
@getvictor
Merge remote-tracking branch 'origin/main' into victor/android-poc
7c43db3
@getvictor
Applied refactorings from main.
29b39e8
@getvictor
Minor fixes
fe58e34
@getvictor
Merge remote-tracking branch 'origin/victor/android-poc' into victor/…
759c08f 
…26218-android-turn-on
@getvictor
WIP preparing for real Android implementation
5b4c3de
@getvictor
Merge remote-tracking branch 'origin/main' into victor/26218-android-…
5a61ea4 
…turn-on
@getvictor
Refactoring
35d9fde
@getvictor
Refactoring
a47516e
@getvictor
Refactoring, still
3d93714
@getvictor
Refactoring, still
caaa56f
@getvictor
Refactoring, done?
e1471d4
@getvictor
Cleanup
f79f67f
@getvictor
Removed AndroidCron const.
0b041d9
@getvictor
Fix issues in manual testing.
0f916e2
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 21, 2025
View reviewed changes
@getvictor getvictor marked this pull request as ready for review February 21, 2025 20:12
@getvictor getvictor requested a review from a team as a code owner February 21, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@getvictor