Terraform cleanup

[noahtalerman]

@noahtalerman: I was chatting with @edwardsb and learned that we moved the best practice Terraform (for AWS) to a separate repo here.

Now that the best practice Terraform lives there, can we remove this dogfood/aws/ folder.

Changes:

• Remove dogfood/aws/ folder
• Update links in docs and guides

[noahtalerman]

@noahtalerman: I was chatting with @edwardsb and learned that we moved the best practice Terraform (for AWS) to a separate repo here.

Now that the best practice Terraform lives there, can we remove this dogfood/aws repo? One less things to maintain. If yes, I can update the links in various spots in the repo/docs.

@rfairburn what do you think?

cc @lukeheath

[rfairburn]

We don't use/maintain this at all and we haven't recommended it at all since the terraform modules were initially created. I know we kept it around for a while because some customers had existing infrastructure that used the legacy dogfood terraform, but eventually this should go away. I think now is probably a good time for that to happen

[noahtalerman]

I know we kept it around for a while because some customers had existing infrastructure that used the legacy dogfood terraform, but eventually this should go away. I think now is probably a good time for that to happen

Sounds good 👍

@rfairburn do we maintain the GCP Terraform? Wondering if we can remove that too.

[lukeheath]

Fine with me 👍

[noahtalerman]

FYI failing website test is unrelated to these changes:

[rfairburn]

@rfairburn do we maintain the GCP Terraform? Wondering if we can remove that too.

The GCP Terraform is at least minimally maintained. It's a good starting point for anyone using GCP and we have no alternative there. I wouldn't remove it at this point, personally.

[noahtalerman]

@rfairburn @rachaelshaw can you please take another look? I had to resolve some merge conflicts.

If everything looks good please feel free to merge to avoid future conflicts :)