Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always allow passwords for users #26334

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Feb 13, 2025

#25834

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (ba8b94c) to head (b3453c0).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
server/service/users.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26334      +/-   ##
==========================================
- Coverage   63.88%   63.79%   -0.10%     
==========================================
  Files        1632     1650      +18     
  Lines      157962   158676     +714     
  Branches     4089     4037      -52     
==========================================
+ Hits       100918   101228     +310     
- Misses      49147    49521     +374     
- Partials     7897     7927      +30     
Flag Coverage Δ
frontend 53.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review February 14, 2025 14:29
@dantecatalfamo dantecatalfamo requested review from a team as code owners February 14, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants