Show "Manage Automations" dropdown when no policies are present #26298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26298 +/- ##
==========================================
- Coverage 63.85% 63.84% -0.01%
==========================================
Files 1632 1632
Lines 157936 157938 +2
Branches 4038 4091 +53
==========================================
- Hits 100843 100838 -5
- Misses 49191 49198 +7
Partials 7902 7902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@noahtalerman I only saw tooltip verbiage for one state, so I added variations for the free tier and for when "All Teams" is selected (see screenshots in description). Let me know if you want changes to the text. |
Hey @sgress454! Up to @marko-lisica (Product Designer for the user story):
|
Great catch @sgress454! I just added these 2 cases to Figma here 
I noticed that the tooltips on the screenshots don't have a caret (arrow) pointing to the button and a copy doesn't match what's specified in Figma. We use one without caret only with underlined text. Tooltip w/o caret: Tooltip w/ caret: |
|
Thanks @marko-lisica! Updated:
|
| } | ||
|
|
||
| automationsDropdown = ( | ||
| <TooltipWrapper underline={false} tipContent={tipContent} showArrow> |
There was a problem hiding this comment.
looks like we want position="top"
| /> | ||
| </div> | ||
| ); | ||
| if (!hasPoliciesToAutomateOrDelete) { |
There was a problem hiding this comment.
Our general pattern for this kind of thing would be more like:
const tipContent =
isPremiumTier && currentTeamId !== APP_CONTEXT_ALL_TEAMS_ID ? (
<>
To manage automations add a policy to this team.
<br />
For inherited policies select “All teams”.
</>
) : (
"To manage automations add a policy."
);
, though I like this let-based version too. If you feel like we should shift in that direction in
general, can you bring it up as a topic at frontend sync? Otherwise let's stick with the
ternary-based approach please.
Also, nice effort towards using more semantic HTML! I will say in my experience in the codebase,
using <p> tends to introduce more style issues than it solves. I'd support a concerted app-wide effort
to use more semantic markup, though caution that currently it tends to introduce more problems than
it solves.
| @@ -55,6 +55,10 @@ | |||
| .form-field { | |||
| margin-bottom: 0; | |||
| } | |||
|
|
|||
| &__tooltip { | |||
| text-align: center; | |||
There was a problem hiding this comment.
related to the <p>, right?
For #23243
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Details
This PR changes the behavior of the Manage Automations dropdown on the Manage Policies page. Any user that has permission to manage policies will now always see the dropdown. If there are no policies added for the selected team (or no policies at all, in the case of "All teams" or users on the free tier), the dropdown is disabled with a tooltip.
Screenshots
Free tier:
Premium tier, All Teams:
Premium tier, team selected:
