Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't truncate text in SQL editor #26292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgress454
Copy link
Contributor

@sgress454 sgress454 commented Feb 12, 2025

For #25921

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Details

This PR fixes an issue where the SQL editor would truncate large queries, because it was setting a mandatory height on the content element rather than letting the element use its own computed height.

Screenshots

Before:
25921-before

After:
25921-after

@sgress454 sgress454 requested a review from a team as a code owner February 12, 2025 17:04
@@ -29,7 +29,7 @@
}

.ace-fleet .ace_content {
height: 100% !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been here from the very beginning. The editor sets a height on the content programmatically, which this has been overriding. If anyone knows a case where this was necessary, let me know.

Copy link
Contributor

@ghernandez345 ghernandez345 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this was here. Seems ok to remove; will keep this in mind if some bugs come up in the editor later.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (606df3f) to head (5f198a5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #26292   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files        1632     1632           
  Lines      157936   157936           
  Branches     4038     4089   +51     
=======================================
  Hits       100843   100843           
  Misses      49191    49191           
  Partials     7902     7902           
Flag Coverage Δ
frontend 53.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -29,7 +29,7 @@
}

.ace-fleet .ace_content {
height: 100% !important;
Copy link
Contributor

@ghernandez345 ghernandez345 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this was here. Seems ok to remove; will keep this in mind if some bugs come up in the editor later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants