-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't truncate text in SQL editor #26292
base: main
Are you sure you want to change the base?
Conversation
@@ -29,7 +29,7 @@ | |||
} | |||
|
|||
.ace-fleet .ace_content { | |||
height: 100% !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been here from the very beginning. The editor sets a height on the content programmatically, which this has been overriding. If anyone knows a case where this was necessary, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this was here. Seems ok to remove; will keep this in mind if some bugs come up in the editor later.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26292 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 1632 1632
Lines 157936 157936
Branches 4038 4089 +51
=======================================
Hits 100843 100843
Misses 49191 49191
Partials 7902 7902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -29,7 +29,7 @@ | |||
} | |||
|
|||
.ace-fleet .ace_content { | |||
height: 100% !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why this was here. Seems ok to remove; will keep this in mind if some bugs come up in the editor later.
For #25921
Checklist for submitter
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
Details
This PR fixes an issue where the SQL editor would truncate large queries, because it was setting a mandatory height on the content element rather than letting the element use its own computed height.
Screenshots
Before:
![25921-before](https://private-user-images.githubusercontent.com/553428/412533059-19e6e4ea-6ec4-4451-80c7-c5fa061353d7.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTUyODgsIm5iZiI6MTczOTU5NDk4OCwicGF0aCI6Ii81NTM0MjgvNDEyNTMzMDU5LTE5ZTZlNGVhLTZlYzQtNDQ1MS04MGM3LWM1ZmEwNjEzNTNkNy5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNDQ5NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YmU1YTA5YzBjMjRmN2U5ZGE3MjE0MmIzNzcxMTM2MGEwNzJmZWFkNDFhYWMxMGNiZGUzYmRhMTFkMTZiNGU1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.bWlPpdigXqKedxvVOgo789Rwn-q0CNIUKMq0QmEDUAM)
After:
![25921-after](https://private-user-images.githubusercontent.com/553428/412533086-26c80f89-4bd7-4f43-9d28-531fff945aba.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTUyODgsIm5iZiI6MTczOTU5NDk4OCwicGF0aCI6Ii81NTM0MjgvNDEyNTMzMDg2LTI2YzgwZjg5LTRiZDctNGY0My05ZDI4LTUzMWZmZjk0NWFiYS5naWY_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNDQ5NDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZjZkZjgxMTUwZTMwNzQ3ZjkzMWUxNDhiZGYxMTk1NmJlYzI1ZDUwZmUxNDJkZTFlNmY4ODgwYTJlOWFjZjY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.22iu_jOEV0sYTGBPEEJai2jjpVqGDvdS0zlqUcd6_b4)