Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction on setting both metadata and metadata_url #26279

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Feb 11, 2025

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (1e3d735) to head (ffed1bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26279      +/-   ##
==========================================
- Coverage   63.88%   63.88%   -0.01%     
==========================================
  Files        1632     1632              
  Lines      157962   157959       -3     
  Branches     4038     4038              
==========================================
- Hits       100908   100906       -2     
+ Misses      49154    49153       -1     
  Partials     7900     7900              
Flag Coverage Δ
backend 64.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review February 13, 2025 14:20
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner February 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants