Fleet UI: Clean up TabNav and TargetChipSelector components #26256
+637
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelElysia
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26256 +/- ##
=======================================
Coverage 63.66% 63.66%
=======================================
Files 1631 1633 +2
Lines 156545 156558 +13
Branches 4046 4045 -1
=======================================
+ Hits 99657 99673 +16
+ Misses 49038 49034 -4
- Partials 7850 7851 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RachelElysia
commented
Feb 11, 2025
| import SearchField from "components/forms/fields/SearchField"; | ||
| import RevealButton from "components/buttons/RevealButton"; | ||
| import TargetPillSelector from "./TargetChipSelector"; |
There was a problem hiding this comment.
Moved to separate directory/file to add unit tests, storybook, organize styling
RachelElysia
commented
Feb 11, 2025
| } | ||
| &__tab { | ||
| padding: $pad-small 0; | ||
| padding: $pad-small 0 $pad-medium; |
There was a problem hiding this comment.
new per figma design
RachelElysia
commented
Feb 11, 2025
| position: sticky; | ||
| top: 0; | ||
| background-color: $core-white; | ||
| z-index: 2; | ||
|
|
||
| .react-tabs { | ||
| &__tab-list { | ||
| border-bottom: 1px solid $ui-gray; | ||
| border-bottom: 1px solid $ui-fleet-black-10; |
RachelElysia
commented
Feb 11, 2025
| @@ -34,7 +34,7 @@ | |||
| } | |||
|
|
|||
| &:hover { | |||
| box-shadow: inset 0 0 0 1px $core-vibrant-blue-over; | |||
| background-color: $ui-vibrant-blue-10; | |||
There was a problem hiding this comment.
changed hover state per figma design
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
RachelElysia
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Part 1 For #26231
Description
Screenshot/screen recording
TODO: After designs are finalized
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.