Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch templates from GraphQL, deprecate templates.json #489

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

nemanjafleek
Copy link

@nemanjafleek nemanjafleek commented Feb 4, 2025

Why?

Templates should be fetched via the existing GraphQL api, templates.json and related assets should be removed.

Status (7th February): on hold. We will use website templates.json in the dashboard.

https://discord.com/channels/1045027913260617789/1045488357846814771/1337102123875434546

Todo:

How?

  • Add GraphQL query to fetch the templates.
  • Map GraphQL template type to the existing templates.json type so that the existing rendering logic can remain unchanged.

Tickets?

This is the ticket but the requirements are outdated and completely opposite. We wont use template.json in the dashboard but instead we will use GraphQL endpoint in the website.

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • Document filename is named after the slug
  • You've reviewed spelling using a grammar checker
  • For documentation, guides or references, you've tested the commands and steps
  • You've done enough research before writing

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)
  • The Components are escaping output (to prevent XSS)

References?

Optionally, provide references such as links

Preview?

Screenshot video, work in progress (6th February):

templates.in.progress.webm

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: c0ba821

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants