FOGL-8175: Updated the system test that requires stats collection “per asset & service” by Mohit04tomar · Pull Request #1193 · fledge-iot/fledge

Mohit04tomar · 2023-10-11T07:36:52Z

Below are the jobs that I run with the changes:

fledge_packages_pair_system_test_c_north_service_ub1804/515/
fledge_packages_pair_system_test_python_north_service_ub1804/539/
fledge_packages_pair_system_test_python_north_service_ub20x86_ub18aarch64/598/
fledge_packages_pi_web_api/611/
fledge_packages_pi_web_api_2021sp2/220/
fledge_packages_system_test_north_service_ub1804/452/
fledge_packages_system_test_north_service_ub1804_piwebapi2021sp2/217/
fledge_packages_system_test_OMF_naming_scheme_ub2004/430/
fledge_packages_system_test_pi_web_api_2021sp3_linked_data_type/143/
fledge_nightly_build_ub1804/1732/
fledge_nightly_build_ub2004/1047/
fledge_nightly_build_ubuntu18_aarch64/158/
fledge_packages_system_test_stats_history_notification_rule/82/
fledge_packages_system_test_eds/568/

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

… FOGL-8175

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

ashish-jabble · 2023-10-12T09:51:34Z

tests/system/python/smoke/test_smoke.py



-def test_smoke(start_south_coap, fledge_url, wait_time, asset_name="smoke"):
+def test_smoke(start_south_coap, update_stat_collection, fledge_url, wait_time, asset_name="smoke"):


For smoke tests - I suggest we should verify with default configuration setup.

ashish-jabble · 2023-10-12T09:55:25Z

tests/system/python/conftest.py

+
+@pytest.fixture
+def update_stat_collection(fledge_url, wait_time):
+    """Update the Stat colectioin of all south service to per asset & service"""


Statistics Collection

Also this fixture should provide facility for a single south service as well.

ashish-jabble · 2023-10-12T09:56:16Z

tests/system/python/conftest.py

+    """Update the Stat colectioin of all south service to per asset & service"""
+
+    # Wait for the south service to be created
+    time.sleep(wait_time)


Remove extra delay from here. This fixture should call when service is up

We can call once added in disable mode as well; and advance category is available? So not necessarily when up.

This sleep is used to wait for the creation of the advanced category. Since this fixture is called immediately after the South service is created, the sleep is added here to prevent failures caused by delays in the creation of the advanced category, even in disabled mode.

ashish-jabble · 2023-10-12T09:58:08Z

tests/system/python/e2e/test_e2e_kafka.py

                "schedule_day": 0,
                "schedule_time": 0,
-                "schedule_repeat": 0,
+                "schedule_repeat": 5,


This means that task never runs/execute before as its type is INTERVAL?
For nightly system tests, Are we running with skip_verify_north_interface?

ashish-jabble · 2023-10-12T10:17:14Z

tests/system/python/pair/test_c_north_service_pair.py

 import time
 import urllib.parse
 from pathlib import Path
+from urllib.parse import quote


We already have import in L#16

ashish-jabble · 2023-10-12T10:18:02Z

tests/system/python/pair/test_c_north_service_pair.py

+    for service in response["services"]:
+        put_url = "/fledge/category/{}Advanced".format(service["name"])
+        payload = {"statistics": "per asset & service"}
+        res = utils.put_request(fledge_url, quote(put_url), payload)


Use with - urllib.parse.quote(put_url)

ashish-jabble · 2023-10-12T10:18:24Z

tests/system/python/pair/test_c_north_service_pair.py



+def update_stat_collection_remote(fledge_url, wait_time):
+    """Update the Stat colectioin of all south service to per asset & service"""


Statistics Collection

ashish-jabble · 2023-10-12T10:18:32Z

tests/system/python/pair/test_c_north_service_pair.py

+    """Update the Stat colectioin of all south service to per asset & service"""
+
+    # Wait for the south service to be created
+    time.sleep(wait_time)


ashish-jabble · 2023-10-12T10:19:06Z

tests/system/python/pair/test_e2e_fledge_pair.py

 class TestE2eFogPairPi:

+    def update_stat_collection_remote(fledge_url, wait_time):
+        """Update the Stat colectioin of all south service to per asset & service"""


Statistics Collection

ashish-jabble · 2023-10-12T10:19:30Z

tests/system/python/pair/test_pyton_north_service_pair.py

 import time
 import urllib.parse
 from pathlib import Path
+from urllib.parse import quote


ashish-jabble · 2023-10-12T10:19:55Z

tests/system/python/pair/test_pyton_north_service_pair.py

+    for service in response["services"]:
+        put_url = "/fledge/category/{}Advanced".format(service["name"])
+        payload = {"statistics": "per asset & service"}
+        res = utils.put_request(fledge_url, quote(put_url), payload)


Use urllib.parse.quote(put_url)

ashish-jabble · 2023-10-12T10:20:05Z

tests/system/python/pair/test_pyton_north_service_pair.py



+def update_stat_collection_remote(fledge_url, wait_time):
+    """Update the Stat colectioin of all south service to per asset & service"""


Statistics Collection

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

ashish-jabble · 2023-10-13T13:11:58Z

fyi, FOGL-8190 Temporarily change the default statistics collection back to per asset

ashish-jabble · 2025-09-25T06:49:58Z

@Mohit04tomar Is there anything remaining for this PR, or is it outdated and can be closed? Since we've now reverted the stats collection option, it may no longer be relevant.

Mohit04tomar and others added 8 commits October 10, 2023 17:22

Added fixture to update statistics collection of south services

1af0703

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Updated package based tests

2aeba35

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Updated pair based system test

eb6bb2d

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Updated nightly test

c95e656

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Updated e2e/test_e2e_coap_PI.py test

7b89fe1

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Added code for updating stat collection of remote system properly

2ffdbf7

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Minor fix

40817d5

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Merge branch 'develop' into FOGL-8175

7253125

Mohit04tomar marked this pull request as ready for review October 12, 2023 06:52

Mohit04tomar added 3 commits October 12, 2023 14:06

Refactored Code

d34b7d4

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Merge branch 'FOGL-8175' of https://github.com/fledge-iot/fledge into…

485a0e2

… FOGL-8175

Refactored Code -2

61a096a

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Mohit04tomar requested review from YashTatkondawar, ashish-jabble and praveen-garg and removed request for ashish-jabble and praveen-garg October 12, 2023 09:48

Mohit04tomar changed the title ~~FOGL-8175~~ FOGL-8175: Updated the system test that requires stats collection “per asset & service” Oct 12, 2023

ashish-jabble reviewed Oct 12, 2023

View reviewed changes

Mohit04tomar added 3 commits October 12, 2023 16:41

Feedback changes

92a53d0

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Feedback changes

923582a

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Minor fix

35fe197

Signed-off-by: Mohit Singh Tomar <M.singh19994@gmail.com>

Mohit04tomar requested a review from ashish-jabble October 13, 2023 09:16

ashish-jabble mentioned this pull request Oct 13, 2023

FOGL-8190 Temporarily revert to statistics collection per asset and #1196

Merged

ashish-jabble added the hold on hold label Oct 16, 2023



		def test_smoke(start_south_coap, fledge_url, wait_time, asset_name="smoke"):
		def test_smoke(start_south_coap, update_stat_collection, fledge_url, wait_time, asset_name="smoke"):



		def update_stat_collection_remote(fledge_url, wait_time):
		"""Update the Stat colectioin of all south service to per asset & service"""

Conversation

Mohit04tomar commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashish-jabble Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashish-jabble commented Oct 13, 2023

Uh oh!

ashish-jabble commented Sep 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mohit04tomar commented Oct 11, 2023 •

edited

Loading

ashish-jabble Oct 12, 2023 •

edited

Loading