chore(deps): update go, golangci, gorelease

Address the warnings raised by latest version of golangci

Signed-off-by: Flavio Castelli <[email protected]>

.github/workflows/ci.yml

@@ -24,7 +24,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.22"
       - run: go test ./...
 
   golangci:
@@ -34,8 +34,8 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.22"
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.55.2
+          version: v1.58.2

.github/workflows/release.yml

@@ -22,10 +22,10 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.21.x
+          go-version: 1.22.x
       - uses: sigstore/cosign-installer@v3
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v5.0.0
+        uses: goreleaser/goreleaser-action@v5.1.0
         with:
           distribution: goreleaser
           version: latest

Makefile

@@ -14,7 +14,7 @@ GO_VERSION_MAJ := $(shell echo $(GO_VERSION) | cut -f1 -d'.')
 GO_VERSION_MIN := $(shell echo $(GO_VERSION) | cut -f2 -d'.')
 
 # golangci linter
-GOLANGCI_LINT_VER := v1.55.2
+GOLANGCI_LINT_VER := v1.58.2
 GOLANGCI_LINT_BIN := golangci-lint
 GOLANGCI_LINT := $(BINPATH)/$(GOLANGCI_LINT_BIN)
 

cmd/kuberlr/bins.go

@@ -27,7 +27,7 @@ func NewBinsCmd() *cobra.Command {
 	return &cobra.Command{
 		Use:   "bins",
 		Short: "Print information about the kubectl binaries found",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			kubectlFinder := finder.NewKubectlFinder("", "")
 			systemBins, err := kubectlFinder.SystemKubectlBinaries()
 

cmd/kuberlr/get.go

@@ -23,7 +23,7 @@ func NewGetCmd() *cobra.Command {
   
   Versions can be specified with, or without the 'v' prefix:
   $ kuberlr get v1.19.1`,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, args []string) error {
 			version, err := semver.ParseTolerant(args[0])
 			if err != nil {
 				return fmt.Errorf("invalid version: %w", err)

cmd/kuberlr/main.go

@@ -36,7 +36,7 @@ func NewKubectlWrapperCmd() *cobra.Command {
 		Use:                "kubectl",
 		Short:              "Wrap and exec a suitable version kubectl command",
 		DisableFlagParsing: true,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			kubectlWrapperMode(args)
 		},
 	}

cmd/kuberlr/version.go

@@ -14,7 +14,7 @@ func NewVersionCmd() *cobra.Command {
 	return &cobra.Command{
 		Use:   "version",
 		Short: "Print version information",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			//nolint: forbidigo
 			fmt.Printf("%s\n", kuberlr.CurrentVersion().String())
 		},

internal/config/config.go

@@ -9,6 +9,8 @@ import (
 	"github.com/flavio/kuberlr/internal/common"
 )
 
+const DefaultTimeout = 5
+
 // Cfg is used to retrieve the configuration of kuberlr
 type Cfg struct {
 	Paths []string
@@ -29,7 +31,7 @@ func (c *Cfg) Load() (*viper.Viper, error) {
 	v := viper.New()
 	v.SetDefault("AllowDownload", true)
 	v.SetDefault("SystemPath", common.SystemPath)
-	v.SetDefault("Timeout", 5)
+	v.SetDefault("Timeout", DefaultTimeout)
 	v.SetDefault("KubeMirrorUrl", "https://dl.k8s.io")
 
 	v.SetConfigType("toml")

internal/downloader/download.go

@@ -62,7 +62,7 @@ func (d *Downloder) UpstreamStableVersion() (semver.Version, error) {
 	if err != nil {
 		return semver.Version{}, err
 	}
-	url, err := url.Parse(fmt.Sprintf("%s/release/stable.txt", baseURL))
+	url, err := url.Parse(baseURL + "/release/stable.txt")
 	if err != nil {
 		return semver.Version{}, err
 	}
@@ -101,6 +101,7 @@ func (d *Downloder) GetKubectlBinary(version semver.Version, destination string)
 			}
 		}
 
+		//nolint: mnd
 		err = d.download(fmt.Sprintf("kubectl%s%s", version, osexec.Ext), downloadURL, hashing, destination, 0755)
 		if err == nil {
 			return nil
@@ -188,8 +189,8 @@ func (d *Downloder) download(desc string, urlToGet string, hashing *Hashing, des
 		progressbar.OptionSetDescription(desc),
 		progressbar.OptionSetWriter(os.Stderr),
 		progressbar.OptionShowBytes(true),
-		progressbar.OptionSetWidth(40),
-		progressbar.OptionThrottle(10*time.Millisecond),
+		progressbar.OptionSetWidth(40),                  //nolint: mnd
+		progressbar.OptionThrottle(10*time.Millisecond), //nolint: mnd
 		progressbar.OptionShowCount(),
 		progressbar.OptionOnCompletion(func() {
 			fmt.Fprintln(os.Stderr, " done.")

internal/finder/kubectl_finder.go

@@ -189,6 +189,7 @@ func lowerBoundVersion(v semver.Version) semver.Version {
 }
 
 func upperBoundVersion(v semver.Version) semver.Version {
+	//nolint: mnd
 	return semver.Version{
 		Major: v.Major,
 		Minor: v.Minor + 2,

internal/finder/test_helper.go

@@ -67,7 +67,7 @@ func createFakeKubectlBinaries(bins KubectlBinaries) error {
 		_, err := os.Stat(dir)
 		if err != nil {
 			if os.IsNotExist(err) {
-				err = os.MkdirAll(dir, 0755)
+				err = os.MkdirAll(dir, 0755) //nolint: mnd
 				if err != nil {
 					return err
 				}

internal/finder/versioner.go

@@ -47,6 +47,12 @@ func NewVersioner(f iFinder) *Versioner {
 	}
 }
 
+const (
+	_ = iota
+	VerbosityOne
+	VerbosityTwo
+)
+
 // KubectlVersionToUse returns the kubectl version to be used to interact with
 // the remote server. The method takes into account different failure scenarios
 // and acts accordingly.
@@ -56,15 +62,15 @@ func (v *Versioner) KubectlVersionToUse(timeout int64) (semver.Version, error) {
 		if isUnreachable(err) {
 			// the remote server is unreachable, let's get
 			// the latest version of kubectl that is available on the system
-			klog.V(2).Info("Remote kubernetes server unreachable")
+			klog.V(VerbosityTwo).Info("Remote kubernetes server unreachable")
 		} else {
-			klog.V(1).Info(err)
+			klog.V(VerbosityOne).Info(err)
 		}
 		kubectl, internalErr := v.kFinder.MostRecentKubectlAvailable()
 		if internalErr == nil {
 			return kubectl.Version, nil
 		} else if common.IsNoVersionFound(internalErr) {
-			klog.V(2).Info("No local kubectl binary found, fetching latest stable release version")
+			klog.V(VerbosityTwo).Info("No local kubectl binary found, fetching latest stable release version")
 			return v.downloader.UpstreamStableVersion()
 		}
 	}

internal/finder/versioner_test.go

@@ -82,7 +82,7 @@ func TestEnsureCompatibleKubectlAvailableLocalBinaryFound(t *testing.T) {
 	expectedPath := "/tmp/kubectl-1.9.0"
 
 	finderMock := mockFinder{}
-	finderMock.findCompatibleKubectl = func(v semver.Version) (KubectlBinary, error) {
+	finderMock.findCompatibleKubectl = func(_ semver.Version) (KubectlBinary, error) {
 		return KubectlBinary{
 			Version: expectedVersion,
 			Path:    expectedPath,
@@ -106,7 +106,7 @@ func TestEnsureCompatibleKubectlAvailableLocalBinaryFound(t *testing.T) {
 // keep
 func TestEnsureCompatibleKubectlAvailableLocalBinaryNotFound(t *testing.T) {
 	finderMock := mockFinder{}
-	finderMock.findCompatibleKubectl = func(v semver.Version) (KubectlBinary, error) {
+	finderMock.findCompatibleKubectl = func(_ semver.Version) (KubectlBinary, error) {
 		return KubectlBinary{}, &common.NoVersionFoundError{}
 	}
 
@@ -203,7 +203,7 @@ func TestKubectlVersionToUseTimeoutAndNoKubectlAvailable(t *testing.T) {
 // keep
 func genericTestKubectlVersionToUseTimeout(localBins, systemBins KubectlBinaries, expected KubectlBinary, downloader *mockDownloader) error {
 	apiMock := mockAPIServer{}
-	apiMock.version = func(timeout int64) (semver.Version, error) {
+	apiMock.version = func(_ int64) (semver.Version, error) {
 		return semver.Version{}, &mockTimeoutError{}
 	}