README: Add 'Getting started' directions #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on #29, but a bit expanded and hopefully addressing concerns on that PR. Omits docs instructions for now as I'm not familiar with how that works.
Contributor
Author
|
I would like to add a section like this at the end, but am unable to actually build the docs locally for some reason, so I'm omitting for now:
|
GeorgesStavracas
requested changes
Jul 28, 2021
Member
GeorgesStavracas
left a comment
GeorgesStavracas
left a comment
There was a problem hiding this comment.
Mostly looks good, clearly an improvement over the single sentence we currently have, but could you please limit the line width to 80 characters?
GeorgesStavracas
requested changes
Jul 28, 2021
Member
GeorgesStavracas
left a comment
GeorgesStavracas
left a comment
There was a problem hiding this comment.
Okay, sorry I didn't catch this in the previous round. I think it's good to land after these adjustments.
GeorgesStavracas
pushed a commit
that referenced
this pull request
Jul 28, 2021
GeorgesStavracas
pushed a commit
to GeorgesStavracas/libportal
that referenced
this pull request
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #29, but a bit expanded and hopefully addressing concerns on that PR. Omits docs instructions for now as I'm not familiar with how that works.