This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos-base/oem-rackspace: Get public and private IP based on routes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not really related to flatcar/bootengine#6 because this script here runs after the initramfs has finished, so it uses the persistent names anyway unless the interface types are excluded (e.g., because they are virtio interfaces). Nevertheless I think we should not hardcode eth0 and eth1, thus the fix. Disclaimer: I did not test it on Rackspace directly, nor do I know if the code actually worked before. |
The OEM package does not set net.ifnames=0 in the kernel command line (as, for example, oem-ec2-compat does) to ensure that ifnames are ethX. Regardless of the ifname scheme, get the public and private IPs based on the routes that get set up or by the prefix they have. https://support.rackspace.com/how-to/basic-network-troubleshooting/ shows that the private IPs (ServiceNet) are 10.x.x.x.
pothos
force-pushed
the
kai/rackspace-get-ips
branch
from
a12d0a0 to
a5cff68
Compare
dongsupark
approved these changes
Feb 20, 2020
|
It needs a rebase |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regardless of the ifname scheme, get the public and private IPs
based on the routes that get set up or by the prefix they have.
https://support.rackspace.com/how-to/basic-network-troubleshooting/
shows that the private IPs (ServiceNet) are 10.x.x.x.