Skip to content

Conversation

@theochap
Copy link
Contributor

@theochap theochap commented Nov 4, 2025

Description

Small PR to bump alloy-rs and reth dependencies.

Tomorrow (Wed Nov 5th), Ithaca will release a new github tag for reth/op-reth. I will update the commit rev to use the new tag then.

EDIT: Updated reth/op-reth to 1.9.0

Copilot AI review requested due to automatic review settings November 4, 2025 21:00
@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rollup-boost Ignored Ignored Preview Nov 6, 2025 10:53pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies across the project, transitioning from reth version 1.8.3 (git tag) to a specific commit revision (c3a60fa), and upgrading alloy-related libraries from version 1.0.37 to 1.0.42, and op-alloy libraries from 0.20.0 to 0.22.0.

Key changes:

  • Switch reth dependencies from git tag v1.8.3 to git revision c3a60fa
  • Upgrade alloy libraries from 1.0.37 to 1.0.42
  • Upgrade op-alloy libraries from 0.20.0 to 0.22.0

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/flashblocks-rpc/Cargo.toml Updates all reth dependencies from tag-based to revision-based references (c3a60fa)
Cargo.toml Updates reth-optimism-payload-builder to revision-based reference and upgrades alloy/op-alloy library versions
Cargo.lock Reflects all transitive dependency updates from the changes above

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 10 to 30
reth-optimism-node = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-optimism-cli = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-rpc-eth-api = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-optimism-primitives = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-optimism-chainspec = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-optimism-rpc = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-optimism-evm = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-optimism-forks = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-provider = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-primitives = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-primitives-traits = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-node-builder = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa", features = [
"test-utils",
] }
reth-e2e-test-utils = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-node-api = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-tasks = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-node-core = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-db = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-tracing = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-rpc-server-types = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-e2e-test-utils = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-node-api = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-tasks = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-node-core = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-db = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-tracing = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-rpc-server-types = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git revision 'c3a60fa' is too short and ambiguous. Git revisions should use the full 40-character SHA or at minimum 7-8 characters to avoid ambiguity. Consider using the full commit hash 'c3a60fa75a30c8b527b63143dc060082bdfee87e' as seen in Cargo.lock.

Copilot uses AI. Check for mistakes.
Cargo.toml Outdated

# Reth deps
reth-optimism-payload-builder = { git = "https://github.com/paradigmxyz/reth", tag = "v1.8.3" }
reth-optimism-payload-builder = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git revision 'c3a60fa' is too short and ambiguous. Git revisions should use the full 40-character SHA or at minimum 7-8 characters to avoid ambiguity. Consider using the full commit hash 'c3a60fa75a30c8b527b63143dc060082bdfee87e' as seen in Cargo.lock.

Suggested change
reth-optimism-payload-builder = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa" }
reth-optimism-payload-builder = { git = "https://github.com/paradigmxyz/reth", rev = "c3a60fa75a30c8b527b63143dc060082bdfee87e" }

Copilot uses AI. Check for mistakes.
@SozinM
Copy link
Collaborator

SozinM commented Nov 5, 2025

they have pushed 1.9.0

Copilot AI review requested due to automatic review settings November 6, 2025 20:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 6, 2025 22:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avalonche avalonche merged commit 2fad970 into flashbots:main Nov 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants