Add config for block selection #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
avalonche
force-pushed
the
block-selection
branch
from
af940b5 to
8a574cc
Compare
avalonche
force-pushed
the
block-selection
branch
from
8a574cc to
49e6731
Compare
0xForerunner
requested changes
Apr 8, 2025
| .payload_inner | ||
| .gas_used; | ||
| let l2_gas_used = l2.0.execution_payload.payload_inner.payload_inner.gas_used; | ||
| if builder_gas_used >= l2_gas_used * self.l2_boost_factor { |
There was a problem hiding this comment.
you're multiplying by an integer here, not a float, so I think we have incorrect behaviour.
|
|
||
| /// percentage multipler to the local payload gas used for choosing payloads | ||
| #[arg(long, env, default_value = "0")] | ||
| l2_boost_factor: u64, |
There was a problem hiding this comment.
I'm not sure l2_boost_factor is a very descriptive name. Maybe we can go with something like --builder-gas-requirement=0.95 and parse a float here instead?
| @@ -133,6 +134,7 @@ impl RollupBoostServer { | |||
| boost_sync: bool, | |||
| metrics: Option<Arc<ServerMetrics>>, | |||
| initial_execution_mode: ExecutionMode, | |||
| l2_boost_factor: u64, | |||
There was a problem hiding this comment.
We probably want some input validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133