Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] chore: PHP 8.4 #4105

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from
Open

[1.x] chore: PHP 8.4 #4105

wants to merge 3 commits into from

Conversation

imorland
Copy link
Member

@imorland imorland commented Nov 9, 2024

Fixes #0000

Changes proposed in this pull request:
Allows newer Laminas versions, so that installation on PHP 8.4 environments is possible.

Due to us maintaining Laravel 8.x compat, PHPStan is currently not possible under 8.4

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland added this to the 1.8.9 milestone Nov 9, 2024
@imorland imorland changed the title chore: php8.4 testing [1.x] chore: PHP 8.4 Nov 9, 2024
@imorland imorland marked this pull request as ready for review November 9, 2024 20:16
@imorland imorland requested a review from a team as a code owner November 9, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant