[1.x] fix: resolve regression in TS typing errors #4097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves regression introduced in #4027
Fixes #0000
If a
shims.d.ts
declaration file doesn't include any import statement, the TS compiler will treat it as an ambient declaration — a type-only interface with no associated value at runtime — which causes regression in other parts of the codebase (notablyextend.ts
).Changes proposed in this pull request:
shims
to work around TypeScript's module augmentation mechanism.Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test
).Required changes: