[tags] Fix wrong tag input width for CJK characters #4094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Add a text measurement utility function in
TagSelectionModal
that is based on canvas'smeasureText
. And make input width prefer this instead ofch
unit.The reason of
ch
unit doesn't work:Reviewers should focus on:
Do you think should we make the measurement utility a globally available function?
Screenshot
Before
After
Necessity
Confirmed
composer test
).Required changes: