Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch formatter to format-message #4088

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 23, 2024

Fixes #3702
Fixes #3734
Fixes #3685
Closes #3735

Changes proposed in this pull request:

  • Switches to the more mature format-message package instead of the less capable one we currently use.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 self-assigned this Oct 23, 2024
@SychO9 SychO9 added this to the 2.0 milestone Oct 23, 2024
@SychO9 SychO9 removed this from the 2.0 milestone Oct 23, 2024
@SychO9
Copy link
Member Author

SychO9 commented Oct 23, 2024

forum side: +3.11KB
admin side: +2.85KB

@SychO9 SychO9 marked this pull request as ready for review October 23, 2024 19:54
@SychO9 SychO9 requested a review from a team as a code owner October 23, 2024 19:54
@SychO9 SychO9 merged commit 73a0296 into 2.x Oct 24, 2024
25 checks passed
@SychO9 SychO9 deleted the sm/replace-js-intl-package branch October 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants