Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] [extensibility] refactor(core): allow labels of PostStreamScrubber to be customized #4049

Merged

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Sep 30, 2024

Fixes #0000

Changes proposed in this pull request:
Improve extensibility in the frontend to allow third-party extensions to more easily customize this component.

Reviewers should focus on:

  • Verify that the backwards compatibility is working as expected. The DOM must be exactly the same.
  • I think that change would also be a good addition to the 2.x branch. Opinions?

Screenshot
No differences

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland added this to the 1.8.6 milestone Sep 30, 2024
@imorland imorland added javascript Pull requests that update Javascript code type/extensibility labels Sep 30, 2024
@DavideIadeluca DavideIadeluca changed the title [1.x] [extensibility] refactor(core): improve improve extensibility of PostStreamScrubber [1.x] [extensibility] refactor(core): improve extensibility of PostStreamScrubber Sep 30, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review September 30, 2024 08:31
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner September 30, 2024 08:31
@DavideIadeluca DavideIadeluca force-pushed the di/poststreamscrubber-extensibility branch from 8131b47 to ee68b36 Compare October 2, 2024 08:03
@DavideIadeluca DavideIadeluca changed the title [1.x] [extensibility] refactor(core): improve extensibility of PostStreamScrubber [1.x] [extensibility] refactor(core): allow labels of PostStreamScrubber to be customized Oct 2, 2024
@DavideIadeluca DavideIadeluca marked this pull request as draft October 2, 2024 08:22
@DavideIadeluca DavideIadeluca force-pushed the di/poststreamscrubber-extensibility branch from ee68b36 to 4707e4e Compare October 2, 2024 08:23
Importing `NestedStringArray` did cause issues in the CI
@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 2, 2024 10:18
@imorland imorland merged commit 12d21cd into flarum:1.x Oct 2, 2024
274 checks passed
@imorland imorland deleted the di/poststreamscrubber-extensibility branch October 2, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants