Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Code Splitting #3860

Merged
merged 47 commits into from
Aug 2, 2023
Merged

feat: Code Splitting #3860

merged 47 commits into from
Aug 2, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jul 27, 2023 •
edited
Loading

Closes #3857

Changes proposed in this pull request:
Read the plan laid out in the issue to understand the changes introduced here.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Related PRs

SychO9 added 30 commits July 27, 2023 14:14
@SychO9
feat: configure webpack to allow splitting chunks
72bf90b 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: JsDirectoryCompiler and expose js assets URL
b1beb8d 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: support es2020 dynamic importing
56391d2 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: control which URL to fetch chunks from
7411195 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: allow showing async modals & split 'LogInModal'
41f26a9 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: split SignUpModal
32064d5 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: allow rendering async pages & split UserSecurityPage
485f9ea 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
fix: module might not be listed in chunk
8e0a621 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: lazy load user pages
d6da281 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: track the chunk containing each module
fff7d6d 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: lightly warn
b1dfe6e 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: split Composer
061964f 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: add common frontend (for split common chunks)
76a30cc 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
fix: jsDoc typing imports should be ignored
2db3f35 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: split PostStream ForgotPasswordModal and EditUserModal
943c6a1 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
fix: multiple inline async imports not picked up
1edfa2a 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: new common frontend assets only needs a jsdir compiler
0643f20 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: add revision hash to chunk import URL
041f62d 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
fix: nothing to split for admin frontend yet
e858a51 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: cleanup registry API
07243dd 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: throw an error in debug mode if attempting to import a non-loa…
6579ea8 
…ded module

Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: defer extend & override until after module registration
b7b4be5 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
fix: plugin not picking up on all module sources
08165dd 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
fix: must override default chunk loader function from webpack plugin
cfbadae 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: split tags TagDiscussionModal and TagSelectionModal
88203dd 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
fix: wrong export name
a1762fe 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: import chunked modules from external packages
adc1134 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: extensions compatibility
dded767 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: Router frontend extender async component
6bd4148 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: clean JS output path (removes stale chunks)
0f1a8f2 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9 SychO9 requested a review from a team as a code owner July 27, 2023 13:14
dsevillamartin
dsevillamartin requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@dsevillamartin dsevillamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like chunk naming doesn't work on Windows. The chunk name ends up being undefined and so breaks the forum.

Works fine on WSL so ik this is (yet another) Windows-only bug 😅

@SychO9
chore(infra): bundlewatch split chunks
8c89979 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
feat: split text editor
982e47b 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: tag typings
12089a4 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
chore: bundlewatch
0152bd9 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9 SychO9 self-assigned this Jul 27, 2023
@SychO9
fix: windows paths
9c97e5d 
Signed-off-by: Sami Mazouz <[email protected]>
@SychO9
Copy link
Member Author

SychO9 commented Aug 2, 2023

Should work on windows now

@SychO9 SychO9 requested a review from imorland August 2, 2023 09:28
@SychO9
Copy link
Member Author

SychO9 commented Aug 2, 2023

Ignore backend failures, will deal with those separately.

imorland
imorland approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @SychO9 👏

@SychO9 SychO9 merged commit 229a7af into 2.x Aug 2, 2023
11 of 19 checks passed
@SychO9 SychO9 deleted the sm/code-splitting branch August 2, 2023 16:57
@SychO9 SychO9 added this to the 2.0 milestone Aug 2, 2023
@SychO9 SychO9 removed their assignment Aug 2, 2023
@SychO9 SychO9 added breaking-changes extension-breaking javascript Pull requests that update Javascript code labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsevillamartin dsevillamartin dsevillamartin requested changes

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
breaking-changes extension-breaking javascript Pull requests that update Javascript code type/feature webpack-config
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Code Splitting
4 participants
@SychO9 @dsevillamartin @imorland @StyleCIBot