Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): run flarum/testing packages tests back again #3844

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

n-peugnet
Copy link
Contributor

These tests were not run on each framework build, I enabled them again. Two of the tests were failing so I disabled them for now, it is more important to have some tests running than none at all.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@n-peugnet n-peugnet requested a review from a team as a code owner June 23, 2023 14:10
@n-peugnet n-peugnet marked this pull request as draft June 23, 2023 14:10
These tests were not run on each framework build, I enabled them again.
Two of the tests were failing so I disabled them for now, it is more
important to have some tests running than none at all.
It is useless now that the tests are run in the framework repo.
Also this workflow was not working anymore.
@n-peugnet n-peugnet marked this pull request as ready for review June 23, 2023 14:41
@n-peugnet
Copy link
Contributor Author

Just a comment to make it clear that this PR removes the CI that was run on each release in flarum/testing repo, as it now useless if the tests are run on each push to master in flarum/framework. It was failing anyway.

# Conflicts:
#	.github/workflows/backend.yml
#	composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants