Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mentions): add integration test for reply approval notification #3748

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

OrdinaryJellyfish
Copy link
Contributor

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@OrdinaryJellyfish OrdinaryJellyfish requested a review from a team as a code owner March 7, 2023 17:04
SychO9
SychO9 previously approved these changes Apr 16, 2023
@SychO9 SychO9 dismissed their stale review April 24, 2023 14:06

Not sure why I assumed this was completed, looking again it isn't. @OrdinaryJellyfish could you look into this please

@SychO9 SychO9 changed the base branch from main to 2.x May 27, 2023 17:41
@SychO9 SychO9 added this to the 2.0 milestone Oct 22, 2024
@SychO9 SychO9 merged commit f729a4d into 2.x Oct 22, 2024
25 checks passed
@SychO9 SychO9 deleted the tk/post-reply-test branch October 22, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants