Skip to content

Commit

Permalink
[1.x] chore: resolve node deprecation warnings in workflows (#4081)
Browse files Browse the repository at this point in the history
* chore: update frontend workflow

Backport of 356f976

* chore: bump default node version and `flarum/action-build`

* fix

* dummy commit
  • Loading branch information
DavideIadeluca authored Oct 22, 2024
1 parent 0b55830 commit 92b2b4a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/REUSABLE_frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ on:
description: The node version to use for the workflow.
type: number
required: false
default: 16
default: 20

js_package_manager:
description: "Enable TypeScript?"
Expand Down Expand Up @@ -105,6 +105,7 @@ env:
ci_script: ${{ inputs.js_package_manager == 'yarn' && 'yarn install --immutable' || 'npm ci' }}
cache_dependency_path: ${{ inputs.cache_dependency_path || format(inputs.js_package_manager == 'yarn' && '{0}/yarn.lock' || '{0}/package-lock.json', inputs.frontend_directory) }}
COMPOSER_AUTH: ${{ secrets.composer_auth }}
DISABLE_V8_COMPILE_CACHE: 1

jobs:
build:
Expand All @@ -116,10 +117,10 @@ jobs:
steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ inputs.node_version }}
cache: ${{ inputs.js_package_manager }}
Expand All @@ -142,7 +143,7 @@ jobs:
working-directory: ${{ inputs.frontend_directory }}

- name: JS Checks & Production Build
uses: flarum/action-build@v3
uses: flarum/action-build@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
build_script: ${{ inputs.build_script }}
Expand Down
1 change: 1 addition & 0 deletions js-packages/tsconfig/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"compilerOptions": {
"skipLibCheck": true,
"allowUmdGlobalAccess": true,
"sourceMap": true,
"strict": true,
Expand Down

0 comments on commit 92b2b4a

Please sign in to comment.