fix(phpstan): code analysis

Signed-off-by: Sami Mazouz <[email protected]>

framework/core/src/Console/Server.php

@@ -14,7 +14,7 @@
 use Flarum\Foundation\SiteInterface;
 use Illuminate\Console\Events\CommandFinished;
 use Illuminate\Console\Events\CommandStarting;
-use Illuminate\Container\Container;
+use Illuminate\Contracts\Container\Container;
 use Illuminate\Events\Dispatcher;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\ConsoleEvents;
@@ -65,9 +65,7 @@ private function handleEvents(Application $console, Container $container): void
             );
         });
 
-        $dispatcher->addListener(ConsoleEvents::ERROR, function (ConsoleErrorEvent $event) {
-            $container = Container::getInstance();
-
+        $dispatcher->addListener(ConsoleEvents::ERROR, function (ConsoleErrorEvent $event) use ($container) {
             /** @var Registry $registry */
             $registry = $container->make(Registry::class);
             $error = $registry->handle($event->getError());

framework/core/src/Foundation/AppInterface.php

@@ -9,11 +9,14 @@
 
 namespace Flarum\Foundation;
 
+use Illuminate\Contracts\Container\Container;
 use Psr\Http\Server\RequestHandlerInterface;
 use Symfony\Component\Console\Command\Command;
 
 interface AppInterface
 {
+    public function getContainer(): Container;
+
     public function getRequestHandler(): RequestHandlerInterface;
 
     /**

framework/core/src/Install/Installer.php

@@ -26,6 +26,11 @@ public function __construct(
     ) {
     }
 
+    public function getContainer(): Container
+    {
+        return $this->container;
+    }
+
     public function getRequestHandler(): RequestHandlerInterface
     {
         $pipe = new MiddlewarePipe;