Merge pull request #18 from fiverr/fix_nodeclass_ref_wrong_docs

Fix nodeclass ref wrong docs
fiverr · Aug 28, 2024 · 6b356d6 · 6b356d6
2 parents 9d07095 + 096b4fe
commit 6b356d6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/charts/karpenter_nodes/Chart.yaml b/charts/karpenter_nodes/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: karpenter_nodes
-version: 1.1.3
+version: 1.1.4
 description: A Helm chart for generating NodeClasses and NodePools for Karpenter
 maintainers:
   - name: nadavbuc
diff --git a/charts/karpenter_nodes/examples/argocd_example.yaml b/charts/karpenter_nodes/examples/argocd_example.yaml
@@ -9,7 +9,7 @@ spec:
   sources:
   - repoURL: 'https://opensource.fiverr.com/public_charts/'
     chart: karpenter_nodes
-    targetRevision: 1.1.3
+    targetRevision: 1.1.4
     helm:
       valueFiles:
       - $values/karpenter_nodes/eks-dev/common.yaml

diff --git a/charts/karpenter_nodes/examples/output/output.yaml b/charts/karpenter_nodes/examples/output/output.yaml
@@ -1088,7 +1088,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-canary-amd64
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       taints:
         - key: dedicated
@@ -1179,7 +1179,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-cilium-managed-amd64
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       taints:
         - key: dedicated
@@ -1266,7 +1266,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-default-amd64
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       requirements:
         - key: "karpenter.k8s.aws/instance-category"
@@ -1433,7 +1433,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-gpu-amd64
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       taints:
         - key: dedicated
@@ -1507,7 +1507,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-ingress-multiarch
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       taints:
         - key: dedicated
@@ -1585,7 +1585,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-jobs-amd64
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       taints:
         - key: dedicated
@@ -1665,7 +1665,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-monitoring-multiarch
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       taints:
         - key: dedicated
@@ -1737,7 +1737,7 @@ spec:
     spec:
       nodeClassRef:
         name: nodes-workers-amd64
-        apiVersion: karpenter.sh/v1
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
       taints:
         - key: dedicated

diff --git a/charts/karpenter_nodes/templates/nodepool.yaml b/charts/karpenter_nodes/templates/nodepool.yaml
@@ -27,7 +27,7 @@ spec:
           {{- $v.nodeClassRef | toYaml | nindent 8 }}
         {{- else }}
         name: {{ $k }}-{{ $v.instances.architecture | default $.Values.instances.architecture }}
-        apiVersion: karpenter.sh/{{ $.Values.ApiVersion }}
+        group: karpenter.k8s.aws
         kind: EC2NodeClass
         {{- end }}
       {{- if or (hasKey $v "taints") (eq ($v.autoTaint | default $.Values.autoTaint) "true") }}