Update OnProductionComplete.tsx

[EndrosG]

Osaka & GoldenGate had wrong effect: PowerPlant
Correct: PowerGrid -- compare ItaipuDam and AkademikLomonosov

PowerPlant = adds another +1 range around the tile, making range 2 effectively range 3.

[insraq]

This fix is wrong. The description says 2-tile range, and it adds power plants with 1-tile range (which is in effect 2-tile range).

[EndrosG]

(fixed it, see detailed comment on 763b7c1)

[insraq]

Your change is not synced in this PR.

[insraq]

Also I would advise against making the change because there're subtle differences and this change might break someone's setup.

[EndrosG]

Your change is not synced in this PR.

I do not understand this. The PR shows 4 changed lines. That's what is intended.

Also I would advise against making the change because there're subtle differences and this change might break someone's setup.

It makes all 4 Wonders with power supply effect work the same way.
Right now: GoldenGateBridge + OsakaCastle = old code, ItaipuDam + AkademikLomonosov = new code.
Same result: all tiles in +2 range become "powerGrid", just with different computation effort because old takes an extra function evaluating "powerPlants" tiles and populating "powerGrid" around "powerPlants".
Old code: make 6 tiles to powerPlants, and for each of the 6 make their adjacent 6 tiles to powerGrid with 7 loop over the map and still ... in the end ... just +18 tiles "powerGrid"
New code: make 18 tiles to powerGrid in one loop.

What kind of setup can be broken the way how ItaipuDam and AkademikLomonosov work compared to GoldenGateBridge + OsakaCastle?

[insraq]

Sorry I was reading an outdated webpage.

I don't remember exactly why it's done this way but I remember there's a reason because I had the same question as you a while ago but decided to keep it. Maybe the scenario no longer applies since electricity has been completely refactored.

If we were to adopt the change, it would need to be thoroughly tested in beta.

[EndrosG]

I'd suggest then that you ask your moderator community like Devonin & co if they know of any difference regarding power supply from the four wonders, specifically from the older two versus newer two as pointed out above.

From my understanding there is no difference. I applied the change in my MOD. But again, my understanding can be uncomplete.
If nobody else is aware of any difference between the two ways, then we should IMHO adopt the change in order to harmonize it to one standard - and to allow the next following change to using const buildingRange throughout the entire file as proposed via Discord.

Until then this PR should just stay open to remind us on that question.