Search functionality not displaying error message when no results are found in the landing Page #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonkec
reviewed
Dec 17, 2024
| @@ -25,9 +25,17 @@ | |||
| margin-top: 40px; | |||
| } | |||
|
|
|||
| div.errorMessage { | |||
There was a problem hiding this comment.
@SrikanthPynaboina can you make error message in red or yellow background? I think users are used to seeing danger messages in red or yellow. What do you think?
| /> | ||
| </div> | ||
| </div> | ||
| <section id='project-list' className='containerLayout'> | ||
|
|
||
| {this.state.error && ( |
There was a problem hiding this comment.
What about showing error messages only if there is nothing in the filterList? Then you don't need another state like error. Maybe that could work 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Change:
After change:
