Fixed most common issues related to the dropdown behaviour and caching in the local storage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr4chinin
changed the title
kr4chinin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version of css theme toggler app I've resolved these problems:
lightclass is now being added to the body programmatically. In the Fireship's version after page reload you could notice that body deriving preffered theme from the local storage and adding it to the already exsisiting one which is hardcoded light theme (so, if preferred theme was dark then after the page reload you will see<body class="light dark">.solarizeButtonacquires normalizeinnerTextproperty. But when page is reloaded it loses its value although the theme is still solarized. Now it will keep it.z-indexproperty so now it is truly unreachable when hidden.pointer-events: auto;property because its implicitly has necessary value.