Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat UX: Use config files and logic overrides #32

Merged
merged 1 commit into from
May 17, 2022
Merged

Feat UX: Use config files and logic overrides #32

merged 1 commit into from
May 17, 2022

Conversation

pascalandy
Copy link
Contributor

@pascalandy pascalandy commented May 17, 2022

Feat UX: Use config files and logic overrides

Requirement:

  • Decouple logic using files: .bashlava_env.sh and .bashlava_env_override.sh
  • At the moment, its too complex for a new user to configure bashlava
  • Let avoid having multiple place to define them, source components, source .md
  • Few array that are configs. They should be all together under the same block of code.

Functional impacts:

  • Dockerfile file is not the place to store config anymore (old logic from https://github.com/firepress-org/ghostfire)
  • Logic for .bashlava_env_override.sh, needed for this env var
    APP_NAME="notset"
    GITHUB_USER="notset"
    APP_VERSION="0.0.1"
  • Update Show_Version()
  • Update Show_Tag()
  • Update Show_Release()
  • remove remove v_and_t()
  • remove Core_Load_Vars_General()
  • remove Core_Load_Vars_Dockerfile()
  • remove Core_Check_Which_File_Exist()
  • File: to check VERSUS file to source
  • Extended Test: Show all var and config (debug)
  • Think about private scripts trigger
  • README docs are still missing, but its ok at this point
  • Impact on: PINNED/ TODO and backlog #4, PINNED/ UX Improvements #8, PINNED/ Logic & Condition 🧠 #10

@pascalandy pascalandy merged commit 41c7784 into main May 17, 2022
@pascalandy pascalandy deleted the edge_c2c branch May 17, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant