Add start time to marker tooltip #4468
Open
+160
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the start time to the marker tooltip in the marker chart. The information was previously only shown in the marker table view, but adding it in the chart view makes it easier to assess if one thing happened before or after another.
I've done this as
<duration> @ <start time>
, but happy for any suggestions as to how to make this readable & obvious.If it's only a marker (i.e. no duration), then we only show the
@ <start time>
(First PR to this repo, always happy for feedback - i missed this feature whilst reviewing some profiles)
┆Issue is synchronized with this Jira Task