-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V8 .heapprofile
importer
#4467
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4467 +/- ##
==========================================
- Coverage 88.63% 88.29% -0.34%
==========================================
Files 293 294 +1
Lines 25981 26101 +120
Branches 6996 7025 +29
==========================================
+ Hits 23027 23047 +20
- Misses 2748 2836 +88
- Partials 206 218 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
d16542c
to
632d47f
Compare
6820f49
to
b950c73
Compare
b950c73
to
26f5e9f
Compare
Hey! Just a quick note that we've seen your PR but just didn't have the chance to look at it during this week. It's still on our radar, thanks for your patience! |
2ef5845
to
766a23b
Compare
766a23b
to
4a253e9
Compare
4a253e9
to
a85e9c0
Compare
Based on #4463
The first commit should display the same data as Chrome/Edge DevTools and VS Code do for
.heapprofile
s.V8 Heap profiles have a
samples
field containing allocation samples. However, as far as I am aware, none of the existing tools actually use that field (properly). Chrome/Edge have an experimental feature to use samples. While this works when recording the heapprofile, the experimental feature breaks importing profiles and end up displaying nothing at all (even the call tree stops working).In the 2nd commit I tried to use
samples
, but I'd like reviewers opinion on it and how to proceed:Additional questions for reviewers:
resourceTable
similar to the chrome importer instead of pushing -1 like dhat?Things left to do:
Home--load-files-from-other-tools
in app.ftl?Fixes #4461
Deploy previews with samples: Chrome profile | Node profile
Deploy previews without samples: Chrome profile | Node profile
Original .heapprofiles used for previews: heapprofiles.zip
┆Issue is synchronized with this Jira Task