[BFP-1052] Adds npm publish workflow #5
Conversation
shahzaib-sheikh
force-pushed
the
shahzaib/bfp-1052-publish-pro-sdk-package-to-npm
branch
from
1e6742e to
c3ca23a
Compare
alawrenc
left a comment
alawrenc
left a comment
There was a problem hiding this comment.
You should probably manually assign Andre or Pedro, since I'm not familiar with the nuance of this setup
| - name: Publish to NPM | ||
| run: npm publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Triple-checking since this is now a public repo: this won't expose the secret via github action logs or any other way?
There was a problem hiding this comment.
This secret is not printed in action logs. as seen here.
The public contributions would require approval from maintainers before it runs gh-actions. e.g. fireflyprotocol/bluefin-v2-client-ts#154
Forks won't have access to this, as mentioned here,
https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow
| environment: "mainnet" | "testnet" | "devnet" = "mainnet", | ||
| private currentAccountAddress: string | null = null, | ||
| basePathConfig: BasePathConfig | null = null, | ||
| basePathConfig: BasePathConfig | null = null |
There was a problem hiding this comment.
The eternal battle of formatters continues!
There was a problem hiding this comment.
I'll make formatting checks as part of PR checks to fix this.
Co-authored-by: André Castelo <[email protected]>
nikita-seedlabs
dismissed stale reviews from andrecastelo and alawrenc
via
ef8a736
4 participants
Adds npm publish workflow