Ksagiyam/tsfc refactor 1 #2200
Merged
Ksagiyam/tsfc refactor 1 #2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/tsfc_refactor_1
branch
4 times, most recently
from
cb79419 to
67203e8
Compare
ksagiyam
force-pushed
the
ksagiyam/tsfc_refactor_1
branch
3 times, most recently
from
7e72e15 to
090b60e
Compare
wence-
reviewed
Oct 28, 2021
firedrake/mg/kernels.py
Outdated
| argument_multiindices = coarse_builder.argument_multiindices | ||
| argument_multiindex, = argument_multiindices | ||
| return_variable, = coarse_builder.set_arguments((ufl.TestFunction(Vc), ), argument_multiindices) | ||
| (return_variable, ) = coarse_builder.return_variables |
Contributor
There was a problem hiding this comment.
Style, should have consistency in the destructuring with the previous line.
ksagiyam
force-pushed
the
ksagiyam/tsfc_refactor_1
branch
from
090b60e to
29f6208
Compare
ksagiyam
force-pushed
the
ksagiyam/tsfc_refactor_1
branch
from
29f6208 to
525c81b
Compare
ksagiyam
force-pushed
the
ksagiyam/tsfc_refactor_1
branch
from
525c81b to
ad6c990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firedrake adjustment for firedrakeproject/tsfc#261.