feat(metrics): store dimensions alongside metrics in store_data #5329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This patch changes the format of the metrics.json to add two keys: metrics, contanining the old dict of metrics, and dimensions, contiaining the dict of dimensions.
We're not storing all other properties as they are the same across all tests on the same executor and they can be fetched from test_result.json already, under "user_properties".
The metrics.json is not used anywhere in the codebase (except some downstream scripts), so this format change won't break anything.
Example:
Reason
In d6e5521b we added a metrics.json to dump all emitted metrics, but we don't add the dimensions to easily parse and know to know to what they refer.
We may want to switch our
ab_test
framework to switch using this file at some point, but that's not really needed.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkbuild --all
to verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.