Eliminate free functions in arch::aarch64::vcpu #5117
Merged
+204
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cached field was only accessed precisely once, so the getter might as well compute it instead. While we're at it, merge the getting with the free-standing computation function. Signed-off-by: Patrick Roy <[email protected]>
Just make this a method on `Aarch64RegisterVec`, and make it return `Option`, because there was only a single error case, and the error message was additionall never displayed because the only call site ignores errors beyond acknowledging that they happened. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5117 +/- ##
==========================================
- Coverage 83.06% 83.06% -0.01%
==========================================
Files 250 250
Lines 26888 26876 -12
==========================================
- Hits 22334 22324 -10
+ Misses 4554 4552 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Almost all the free functions in arch::arch64::vcpu were just taking a vcpu reference as a first parameter (in some form). So just turn these into methods implemented on KvmVcpu that take &self. Signed-off-by: Patrick Roy <[email protected]>
Remove some more .map_err() noise in the mmio device registration code in builder.rs by using #[from] and returning more specialized error types. Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
ShadowCurse
approved these changes
Mar 26, 2025
bchalios
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #5098 I volunteered to do during review
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.