tests: Report kernels newer than 6.12 as next #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
reviewed
Mar 26, 2025
JackThomson2
force-pushed
the
ci/report-kernel-as-upstream
branch
2 times, most recently
from
2cbe529 to
b983aa7
Compare
JackThomson2
changed the title
JackThomson2
force-pushed
the
ci/report-kernel-as-upstream
branch
from
b983aa7 to
4d6743b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5116 +/- ##
======================================================
Coverage 83.06% 83.06%
======================================================
Files 250 250
Lines 26888 26888
======================================================
Hits 22334 22334
Misses 4554 4554
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
approved these changes
Mar 26, 2025
roypat
previously approved these changes
Mar 26, 2025
roypat
force-pushed
the
feature/secret-hiding
branch
from
5573725 to
ad06919
Compare
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
JackThomson2
dismissed
roypat’s stale review
The merge-base changed after approval.
... for context, this apparently happened automatically because I rebased and force-pushed the feature branch |
roypat
approved these changes
Mar 27, 2025
JackThomson2
added
the
Status: Awaiting review
kalyazin
approved these changes
Mar 27, 2025
To make it easier to track the upstream kernels which may change as we rebase, let's mark kernels newer than 6.12 as next for now to make dashboarding easier. Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
ci/report-kernel-as-upstream
branch
from
bcfc7d8 to
a707121
Compare
JackThomson2
merged commit 74de0c9
into
firecracker-microvm:feature/secret-hiding
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When emitting metrics for host kernels greater than 6.12 (latest LTS) we will report them as "next" kernels to make them easier to track in our dashboards
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.